Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: join selectivity #145

Merged
merged 30 commits into from
Mar 31, 2024
Merged

feat: join selectivity #145

merged 30 commits into from
Mar 31, 2024

Conversation

wangpatrick57
Copy link
Member

@wangpatrick57 wangpatrick57 commented Mar 31, 2024 •
edited
Loading

Summary: Implemented join selectivity formulas for inner joins, left/right outer joins, and cross joins. Also properly accounts for filters in the join condition.

Demo:
We now match Postgres on our median Q-error. See #127 for more details on what queries this PR affected.
Screenshot 2024-03-31 at 13 13 48

Details:

  • We only consider equality checks on columns of different tables to be "join on conditions".
  • Join selectivity formulas are from Rogov 2022.
  • If there are multiple on conditions, we multiply their selectivities together.

@wangpatrick57
done with join sel skeleton
f223a93
@wangpatrick57
added filtersel and joinsel const
a20b8f5
@wangpatrick57
made get semantic nodes a function
ccf068d
@wangpatrick57
added tests for log op join sel
88a15e9
@wangpatrick57
refactored per_col_vec to per_col_map to avoid double options
c015562
@wangpatrick57
wrote wrapper to extract join on condition
fdb1c8c
@wangpatrick57
no cache -> rebuild cache
25c2b75
@wangpatrick57
refactored per col from map back to vec
273aa0d
@wangpatrick57
cmt
9e8b4f2
@wangpatrick57
fixed joinsel eq test to use two diff tables
3ff6d24
@wangpatrick57
removed joinsel or test
bbbfbfc
@wangpatrick57
oncond comment
4c792f9
@wangpatrick57
wrote unit tests for join sel
2e23e20
@wangpatrick57
now checking join type inner
3428ebb
@wangpatrick57
fixed q11
673e4aa
@wangpatrick57
cust row cnt
23d0abf
@wangpatrick57
wrote unit tests for outer sel
3836854
@wangpatrick57
refactored unit tests to pass row cnt properly
2f47305
@wangpatrick57
fixed bug in unittests
ff49d83
@wangpatrick57
added sel to hashjoin
3711de2
@wangpatrick57
undid hash join sel
fb141a6
@wangpatrick57
merged with main
7068c83
@wangpatrick57
cross join
5be618e
@wangpatrick57
fmt
4d0f753
@wangpatrick57
clippy
2f5d674
@wangpatrick57
hash join working
cfbca67
@wangpatrick57
clip
0a38dde
@wangpatrick57 wangpatrick57 changed the title Phw2/join sel feat: join selectivity for inner, outer, and cross joins + join filters Mar 31, 2024
@wangpatrick57 wangpatrick57 marked this pull request as ready for review March 31, 2024 17:00
@wangpatrick57 wangpatrick57 mentioned this pull request Mar 31, 2024
Open
22 tasks
@wangpatrick57 wangpatrick57 changed the title feat: join selectivity for inner, outer, and cross joins + join filters feat: join selectivity Mar 31, 2024
@wangpatrick57 wangpatrick57 requested a review from Gun9niR March 31, 2024 17:13
Gun9niR
Gun9niR approved these changes Mar 31, 2024
View reviewed changes
Copy link
Contributor

@Gun9niR Gun9niR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest LGTM

@wangpatrick57 wangpatrick57 merged commit 68666c4 into main Mar 31, 2024
1 check passed
@wangpatrick57 wangpatrick57 deleted the phw2/join-sel branch March 31, 2024 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Gun9niR Gun9niR Gun9niR approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wangpatrick57 @Gun9niR